Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to default overwrite=False in gammapy.maps #1412

Merged
merged 1 commit into from May 13, 2018

Conversation

Projects
None yet
2 participants
@cdeil
Copy link
Member

commented May 8, 2018

This PR changes to default overwrite=False in map.write calls.
This change was discussed here: #1396

@cdeil cdeil added the cleanup label May 8, 2018

@cdeil cdeil added this to the 0.8 milestone May 8, 2018

@cdeil cdeil requested a review from woodmd May 8, 2018

@cdeil

This comment has been minimized.

Copy link
Member Author

commented May 11, 2018

@woodmd - Are you OK to compromise here and change to overwrite=False in gammapy.maps?
(see discussion in #1396 )

@woodmd

This comment has been minimized.

Copy link
Member

commented May 12, 2018

Fine with me although I still think you're going to end up wanting overwrite=True more often than not. We'll just need to make sure that all calls to write in fermipy get updated appropriately.

@woodmd

woodmd approved these changes May 12, 2018

@cdeil

This comment has been minimized.

Copy link
Member Author

commented May 13, 2018

Fine with me although I still think you're going to end up wanting overwrite=True more often than not.

Agreed, this is putting a bad default in the sense that it's not what people want most of the time when typing write. But the argument in #1396 that it's the safe default and the fact that it's the default chosen in Astropy is also a valid one.

Merging now.

@woodmd - Thanks for compromising here!

@cdeil cdeil merged commit ec3d23a into gammapy:master May 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.