Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add map region mask #1421
@registerrier - Thanks!
I left some inline comments.
My main comment / question is concerning if / how to do contains for sky regions. I think the discussions in
astropy-regions have settled on the understanding that sky regions contains isn't well-defined in general and not supported, one always needs a WCS and then does the contains in pixel coordinates, like this:
The exception is circle and polygon regions, for those a spherical contains is well-defined, and those should be implemented in astropy-regions as special classes. But that's not there, so I don't think at the moment we should support it here, which makes we don't support region filtering for HPX at all.
The new commits have:
I realize that there is a serious issue with
This is a serious issue with
Yes, to my understanding this is intended for
OK I have made the modifications.