New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __repr__ methods to Maps and related classes #1435

Merged
merged 4 commits into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Jun 20, 2018

This PR adds __repr__ methods to the Maps, MapsGeom and MapAxis classes.

@adonath adonath self-assigned this Jun 20, 2018

@adonath adonath added the feature label Jun 20, 2018

@cdeil

@adonath - Thanks! Good to have you back for Gammapy!!!

Please add label and milestone, and a test that executes each repr once. IMO no need to assert the full output, but just to make sure it runs is important and the assert could be just on e few characters.

If you want feedback on content it'd be nice to have it visible somewhere (e.g. in docs RST output or pasted to Github issue), but I would suggest to just put that in, and if someone has suggestions they can open a new PR.

Show outdated Hide outdated gammapy/maps/hpx.py

@adonath adonath added this to the 0.8 milestone Jun 20, 2018

@adonath adonath merged commit 34df292 into gammapy:master Jun 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@adonath adonath deleted the adonath:add_maps_repr branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment