New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map smooth method #1444

Merged
merged 6 commits into from Jun 28, 2018

Conversation

3 participants
@AtreyeeS
Contributor

AtreyeeS commented Jun 27, 2018

Added smooth()
removed idx from plot()

@cdeil

@AtreyeeS - Thanks!

See inline comments.

Show outdated Hide outdated gammapy/maps/wcsnd.py
Show outdated Hide outdated gammapy/maps/wcsnd.py
Show outdated Hide outdated gammapy/maps/wcsnd.py
Show outdated Hide outdated gammapy/maps/wcsnd.py
Show outdated Hide outdated gammapy/maps/wcsnd.py
Show outdated Hide outdated gammapy/maps/wcsnd.py

AtreyeeS added some commits Jun 27, 2018

@AtreyeeS

This comment has been minimized.

Show comment
Hide comment
@AtreyeeS

AtreyeeS Jun 27, 2018

Contributor

Thanks @cdeil !
Made the changes as suggested

Contributor

AtreyeeS commented Jun 27, 2018

Thanks @cdeil !
Made the changes as suggested

@cdeil cdeil self-assigned this Jun 27, 2018

@cdeil cdeil added the feature label Jun 27, 2018

@cdeil cdeil added this to the 0.8 milestone Jun 27, 2018

@cdeil cdeil changed the title from Smooth() to Add map smooth method Jun 27, 2018

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 27, 2018

Member

@AtreyeeS - Thanks.

I'll try this out locally and merge soon.

Member

cdeil commented Jun 27, 2018

@AtreyeeS - Thanks.

I'll try this out locally and merge soon.

@cdeil cdeil dismissed their stale review via b0b5cb3 Jun 27, 2018

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 27, 2018

Member

@AtreyeeS - Some fixes in b0b5cb3

For future PRs: suggest to run tests locally, e.g. in this case:

python -m pytest -v gammapy/maps -k smooth

That catches most issues, that then only show up later in CI or for your reviewer:
https://ci.appveyor.com/project/cdeil/gammapy/build/1.0.3532/job/vqji7ug6g9ouvh3v#L1500

@adonath - OK to merge?
(I'm off to see the game now, if there's other issues or changes, can you make them directly, please?)

Member

cdeil commented Jun 27, 2018

@AtreyeeS - Some fixes in b0b5cb3

For future PRs: suggest to run tests locally, e.g. in this case:

python -m pytest -v gammapy/maps -k smooth

That catches most issues, that then only show up later in CI or for your reviewer:
https://ci.appveyor.com/project/cdeil/gammapy/build/1.0.3532/job/vqji7ug6g9ouvh3v#L1500

@adonath - OK to merge?
(I'm off to see the game now, if there's other issues or changes, can you make them directly, please?)

@cdeil cdeil added this to To do in Map analysis via automation Jun 27, 2018

@cdeil cdeil assigned adonath and unassigned cdeil Jun 27, 2018

@adonath adonath self-requested a review Jun 27, 2018

@cdeil

cdeil approved these changes Jun 28, 2018

@adonath

Looks good to me now! The docs build is gives a warning, but I'll fix that in #1443. So I'll go ahead and merge this PR now. Thanks, @AtreyeeS!

@adonath adonath merged commit 5fb39d2 into gammapy:master Jun 28, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

Map analysis automation moved this from To do to Done Jun 28, 2018

@cdeil cdeil referenced this pull request Jun 29, 2018

Closed

Smoothing in gammapy maps #1431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment