Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for setup.py build_docs #1452

Merged
merged 2 commits into from Jul 5, 2018
Merged

Bugfix for setup.py build_docs #1452

merged 2 commits into from Jul 5, 2018

Conversation

wegenmat
Copy link

@wegenmat wegenmat commented Jul 5, 2018 •
edited

This PR is a bugfix for the setup.py build_docs-command, fixing follwoing error message:

File \gammapy\build\lib.win-amd64-3.5\gammapy\utils\docs.py, line 94, in make_link_node

relpath = refuri.split('gammapy/docs/')[1]

IndexError: list index out of range

changed make_link_node to work with both Windows and Linux by using PurePosixPath from pathlib

@cdeil cdeil self-assigned this Jul 5, 2018
@cdeil cdeil added the bug label Jul 5, 2018
@cdeil cdeil added this to the 0.8 milestone Jul 5, 2018
@cdeil
Copy link
Contributor

cdeil commented Jul 5, 2018

@wegenmat - Thanks!

@cdeil cdeil merged commit 51e3a4f into gammapy:master Jul 5, 2018
@wegenmat wegenmat deleted the build_docs-bugfix branch July 9, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdeil cdeil cdeil approved these changes

Assignees

@cdeil cdeil

Labels
bug
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wegenmat @cdeil