New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light curve upper limits #1456

Merged
merged 8 commits into from Jul 10, 2018

Conversation

3 participants
@bkhelifi
Contributor

bkhelifi commented Jul 6, 2018

Hi,
After the work made for the CTA consortium meeting, I made this pull request for only the UL management.
As it is, the LC still produces NaN as the rest of the modifications within spectrum, proposed in the PR #1424, is not pushed.
B.

@bkhelifi bkhelifi added the feature label Jul 6, 2018

@cdeil cdeil assigned cdeil and unassigned registerrier Jul 6, 2018

@cdeil cdeil added feature and removed feature labels Jul 6, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 6, 2018

@cdeil cdeil added this to To do in Time analysis via automation Jul 6, 2018

@cdeil cdeil changed the title from LC: add upper limites to Add light curve upper limits Jul 6, 2018

@cdeil

@bkhelifi - Thank you for splitting this out into a separate PR!

Can you resolve the test fails (see inline comments)?
Or would you prefer I do it and merge?

Show outdated Hide outdated gammapy/stats/tests/test_poisson.py
Show outdated Hide outdated gammapy/time/lightcurve.py
Show outdated Hide outdated gammapy/stats/poisson.py
@cdeil

cdeil approved these changes Jul 10, 2018

Some more pair coding with @bkhelifi just now. Should be OK to merge if CI passes.

@cdeil cdeil merged commit fd19724 into gammapy:master Jul 10, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

Time analysis automation moved this from To do to Done Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment