Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd background to map model evaluator #1470
Conversation
AtreyeeS
added some commits
Jul 10, 2018
adonath
self-assigned this
Jul 10, 2018
adonath
added
the
feature
label
Jul 10, 2018
adonath
added this to To do
in Map analysis
via automation
Jul 10, 2018
adonath
added this to the 0.8 milestone
Jul 10, 2018
AtreyeeS
added some commits
Jul 10, 2018
cdeil
approved these changes
Jul 10, 2018
Looks good to me, and tests pass locally. Merging.
@AtreyeeS - Thanks!
cdeil
merged commit e86f36e
into
gammapy:master
Jul 10, 2018
Map analysis
automation
moved this from To do
to Done
Jul 10, 2018
AtreyeeS
deleted the
AtreyeeS:ModelEval
branch
Jul 10, 2018
adonath
referenced this pull request
Jul 11, 2018
Closed
Change the assert value for fit.stat back to the old one #1466
cdeil
changed the title from
Background added to model evaluator
to
Add background to map model evaluator
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AtreyeeS commentedJul 10, 2018
The SkyModelEvaluator now adds background to the npred.
The fit stats value needed to be changed in the test (also mentioned in @mackaiver PR #1466 )