New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background to map model evaluator #1470

Merged
merged 8 commits into from Jul 10, 2018

Conversation

3 participants
@AtreyeeS
Contributor

AtreyeeS commented Jul 10, 2018

The SkyModelEvaluator now adds background to the npred.

The fit stats value needed to be changed in the test (also mentioned in @mackaiver PR #1466 )

@adonath

I've left a few minor comments, otherwise looks good to me..

Show outdated Hide outdated gammapy/cube/fit.py
Show outdated Hide outdated gammapy/cube/tests/test_fit.py

@adonath adonath self-assigned this Jul 10, 2018

@adonath adonath added the feature label Jul 10, 2018

@adonath adonath added this to To do in Map analysis via automation Jul 10, 2018

@adonath adonath added this to the 0.8 milestone Jul 10, 2018

AtreyeeS added some commits Jul 10, 2018

@cdeil

cdeil approved these changes Jul 10, 2018

Looks good to me, and tests pass locally. Merging.

@AtreyeeS - Thanks!

@cdeil cdeil merged commit e86f36e into gammapy:master Jul 10, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Jul 10, 2018

@AtreyeeS AtreyeeS deleted the AtreyeeS:ModelEval branch Jul 10, 2018

@cdeil cdeil changed the title from Background added to model evaluator to Add background to map model evaluator Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment