New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field-of-view coordinate transformations #1475

Merged
merged 1 commit into from Jul 15, 2018

Conversation

Projects
2 participants
@lmohrmann
Contributor

lmohrmann commented Jul 10, 2018

This PR adds transformations from sky coordinates to field-of-view coordinates and vice versa. This is required e.g. for non-radially-symmetric background maps.

Things that could likely be improved:

  • Use astropy Angle for input and output coordinates?
  • Possibly, SkyOffsetFrame from astropy already provides the same transformation

A test has been added, so it's easy to work on these points and make sure the results are still correct.

@lmohrmann lmohrmann requested a review from cdeil Jul 10, 2018

@cdeil cdeil self-assigned this Jul 11, 2018

@cdeil cdeil added the feature label Jul 11, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 11, 2018

@cdeil cdeil added this to To do in IRFs via automation Jul 15, 2018

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 15, 2018

Member

@lmohrmann - Thanks!

We'll refactor this test in follow-up PRs. It's great to have the good test cases!

Member

cdeil commented Jul 15, 2018

@lmohrmann - Thanks!

We'll refactor this test in follow-up PRs. It's great to have the good test cases!

@cdeil

cdeil approved these changes Jul 15, 2018

@cdeil cdeil merged commit bb35e37 into gammapy:master Jul 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

IRFs automation moved this from To do to Done Jul 15, 2018

@lmohrmann lmohrmann deleted the lmohrmann:add-fov-transforms branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment