Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robust periodogram to gammapy.time #1492

Merged
merged 10 commits into from Jul 12, 2018
Merged

Conversation

@wegenmat
Copy link
Contributor

@wegenmat wegenmat commented Jul 12, 2018

This is a follow-up PR from #1141.
The old PR was closed due to complex history.

@cdeil cdeil self-assigned this Jul 12, 2018
@cdeil cdeil added this to To do in gammapy.time via automation Jul 12, 2018
@cdeil cdeil added this to the 0.8 milestone Jul 12, 2018
@cdeil
cdeil approved these changes Jul 12, 2018
Copy link
Member

@cdeil cdeil left a comment

@wegenmat - Thanks!

Merging now.

@cdeil cdeil merged commit acbeb37 into gammapy:master Jul 12, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.time automation moved this from To do to Done Jul 12, 2018
@cdeil
Copy link
Member

@cdeil cdeil commented Jul 12, 2018

@wegenmat - please have a look at 54b427d

You were referencing images that didn't exist here:
https://github.com/gammapy/gammapy-extra/tree/master/figures/time

Should these images exist and be referenced?
If yes, could you please make a PR to gammapy-extra to add them there?

@wegenmat
Copy link
Contributor Author

@wegenmat wegenmat commented Jul 13, 2018

PR for figures in gammapy-extra online: gammapy/gammapy-extra#110

@wegenmat wegenmat deleted the wegenmat:robust_periodogram_new branch Jul 13, 2018
@cdeil cdeil changed the title Follow-up: Add Robust periodogram to gammapy.time Add robust periodogram to gammapy.time Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.time
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants