Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MapMaker to allow partially contained observations #1495

Merged
merged 4 commits into from Jul 12, 2018

Conversation

2 participants
@AtreyeeS
Copy link
Member

AtreyeeS commented Jul 12, 2018

During DC1 analysis, @robertazanin, @facero and @bkhelifi reported that they would prefer to make the maps with partially contained observations.
This PR allows that, and cleans up the code to access make_cutout from WcsNDMap instead of from cubes/new.py.
Also, the test for MapMaker is changed to check for multiple observations.

@AtreyeeS AtreyeeS added the cleanup label Jul 12, 2018

@AtreyeeS AtreyeeS added this to To do in Map analysis via automation Jul 12, 2018

@AtreyeeS AtreyeeS removed this from To do in Map analysis Jul 12, 2018

@AtreyeeS AtreyeeS added this to To do in Map analysis via automation Jul 12, 2018

@AtreyeeS AtreyeeS requested a review from cdeil Jul 12, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 12, 2018

@cdeil cdeil self-assigned this Jul 12, 2018

AtreyeeS added some commits Jul 12, 2018

@cdeil

cdeil approved these changes Jul 12, 2018

Copy link
Member

cdeil left a comment

Looks good. Thanks!

@cdeil cdeil merged commit 767d3b2 into gammapy:master Jul 12, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Jul 12, 2018

@cdeil cdeil changed the title Modified MapMaker to allow partially contained observations Change MapMaker to allow partially contained observations Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.