New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old background model code #1515

Merged
merged 3 commits into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@cdeil
Member

cdeil commented Jul 16, 2018

This PR removes the old EnergyOffsetArray, FOVCube and FOVCubeBackgroundModel classes in gammapy.background. They were written several years ago, before gammapy.irf (especially the Background2D and Background3D classes) and gammapy.maps existed.

There is some functionality here that we probably want to re-add, to build background models from off data, but IMO it'll be simpler to do from scratch than to incrementally improve and refactor this code. Note that it's always possible to copy and paste from the old code if useful, it'll forever be available in the version history.

@cdeil cdeil added the cleanup label Jul 16, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 16, 2018

@cdeil cdeil merged commit 3fe9b23 into gammapy:master Jul 16, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cdeil cdeil referenced this pull request Jul 26, 2018

Closed

Improve cube bg model production #333

1 of 20 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment