Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove cta_utils and CTASpectrumObservation #1517
This PR removes
I would suggest to merge this now and continue removing duplicated / non-essential things.
But then we still should make the existing examples that people in CTA use work again, i.e. migrate this notebook to use
Jul 16, 2018
I put it on my agenda
Hi @cdeil , @joleroi ,
@jjlk and all - we're not removing everything. The strategy is to never remove something, unless there is an equivalent or better way to do the same thing.
In this case, I think
Just to explain the reason for the cleanup: we have 37,000 lines of code in Gammapy, and about half of that is duplication of functionality. We have to move to a better, clean package to be able to succeed with Gammapy in general, and for the CTA ST selection in the fall specifically. So we're trying to balance short-term pain for the few (10s) of current users with the long-term benefit for the coming years for 100s or 1000s of users. This removal of e.g.
All - please join the Gammapy call this Friday 10 am (https://github.com/gammapy/gammapy-meetings/tree/master/2018-07-20) or let me know if a separate short call would be helpful.
I underdstand your points. But please keep in mind that the main reason we introduced
I'll try to join the call next Friday ++
@jjlk - I understand.
But we still have to do this clean-up, either now before the v0.8 release or in a few weeks after the v0.8 release, or at the very latest before Gammapy v1.0 this fall.
Note that this cleanup of
Let's work together to make this transition. I think on the Gammapy side, the changes to