Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ASmooth to use gammapy.maps #1527

Merged
merged 1 commit into from Jul 17, 2018

Conversation

1 participant
@cdeil
Copy link
Member

cdeil commented Jul 17, 2018

This PR rewrites ASmooth to use gammapy.maps.
The functionality is kept, all tests pass; I hope I didn't break anything.
Merging now.

@adonath - Test coverage for this isn't great, you might want to do a follow-up PR here to adjust the API a bit and improve test coverage for this in the coming weeks (i.e. before Gammapy v1.0 in the fall).

@cdeil cdeil added the cleanup label Jul 17, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 17, 2018

@cdeil cdeil self-assigned this Jul 17, 2018

@cdeil cdeil added this to To do in Map analysis via automation Jul 17, 2018

@cdeil cdeil merged commit 0edb676 into gammapy:master Jul 17, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Jul 17, 2018

@cdeil cdeil changed the title Rewrite ASmooth to use gammapy.maps Migrate ASmooth to use gammapy.maps Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.