New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fermi Vela dataset #156

Merged
merged 3 commits into from Jul 30, 2014

Conversation

Projects
None yet
2 participants
@ellisowen
Contributor

ellisowen commented Jul 26, 2014

Can these be added? I want to use them for the unit tests & tutorial for npred cube and needed a single clear source to do a good comparison between my npred method (see PR #151) and the fermi science tools (so couldn't just use the FermiGalacticCenter stuff). Introduces:
357.1 kB counts_vela.fits.gz
1.5 kB exposure_vela.fits.gz
Are these an OK size to include? I could probably reduce the resolution + size of the counts image once I've written the tutorial & know what is needed there.

I picked the vela region as I already had these files to hand. Could use a different region if preferred.

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 27, 2014

Contributor

I want to make a few changes to this - will push updates shortly.

Contributor

ellisowen commented Jul 27, 2014

I want to make a few changes to this - will push updates shortly.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 28, 2014

Member

The test error on Python 2.6 is a known issue: #147

You have to skip the exposure cube test on Python 2.6 as described here.

Member

cdeil commented Jul 28, 2014

The test error on Python 2.6 is a known issue: #147

You have to skip the exposure cube test on Python 2.6 as described here.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 28, 2014

Member

As discussed, please put the files in the https://github.com/gammapy/gammapy-examples repo (in a data/fermi/vela folder) and only keep the load function and docs page here in the gammapy repo.

Member

cdeil commented Jul 28, 2014

As discussed, please put the files in the https://github.com/gammapy/gammapy-examples repo (in a data/fermi/vela folder) and only keep the load function and docs page here in the gammapy repo.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 29, 2014

Member

I've renamed the repo, you should now add the files in a new sub-folder here.

Member

cdeil commented Jul 29, 2014

I've renamed the repo, you should now add the files in a new sub-folder here.

@ellisowen ellisowen closed this Jul 29, 2014

@ellisowen ellisowen reopened this Jul 29, 2014

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 29, 2014

Contributor

How is this? Please review

Contributor

ellisowen commented Jul 29, 2014

How is this? Please review

Show outdated Hide outdated gammapy/datasets/load.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

The test fails for me: https://gist.github.com/cdeil/c19f2091ada9b6e42e9b
(you have to pass the --remote-data flag and test this locally, this is not tested on travis-ci)

Member

cdeil commented Jul 30, 2014

The test fails for me: https://gist.github.com/cdeil/c19f2091ada9b6e42e9b
(you have to pass the --remote-data flag and test this locally, this is not tested on travis-ci)

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

The reason is that you are downloading an HTML page, not the raw FITS file.

The correct URL is e.g. https://github.com/gammapy/gammapy-extra/raw/master/datasets/vela_region/background_vela.fits

Maybe copy over the get_path utility function to gammapy/datasets/load.py from photutils?
https://github.com/astropy/photutils/blob/master/photutils/datasets/load.py#L42

Member

cdeil commented Jul 30, 2014

The reason is that you are downloading an HTML page, not the raw FITS file.

The correct URL is e.g. https://github.com/gammapy/gammapy-extra/raw/master/datasets/vela_region/background_vela.fits

Maybe copy over the get_path utility function to gammapy/datasets/load.py from photutils?
https://github.com/astropy/photutils/blob/master/photutils/datasets/load.py#L42

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 30, 2014

Contributor

This should now address your comments

Contributor

ellisowen commented Jul 30, 2014

This should now address your comments

Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

This works now.
I've left a few more inline comments ... this can be merged when those are addressed.

Member

cdeil commented Jul 30, 2014

This works now.
I've left a few more inline comments ... this can be merged when those are addressed.

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 30, 2014

Contributor

OK, that I think addresses them

Contributor

ellisowen commented Jul 30, 2014

OK, that I think addresses them

Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/tests/test_load.py Outdated
Show outdated Hide outdated gammapy/datasets/tests/test_load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

You have to rebase this on master, because it conflicts with #152 that I just merged.

Member

cdeil commented Jul 30, 2014

You have to rebase this on master, because it conflicts with #152 that I just merged.

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 30, 2014

Contributor

How is this?

Contributor

ellisowen commented Jul 30, 2014

How is this?

Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
Show outdated Hide outdated gammapy/datasets/load.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

Very close ... two more inline comments above.

Member

cdeil commented Jul 30, 2014

Very close ... two more inline comments above.

@ellisowen

This comment has been minimized.

Show comment
Hide comment
@ellisowen

ellisowen Jul 30, 2014

Contributor

Made those changes...

Contributor

ellisowen commented Jul 30, 2014

Made those changes...

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 30, 2014

Member

Thanks!

Member

cdeil commented Jul 30, 2014

Thanks!

cdeil added a commit that referenced this pull request Jul 30, 2014

@cdeil cdeil merged commit fc829e7 into gammapy:master Jul 30, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@cdeil cdeil changed the title from Fermi source data to Add Fermi Vela dataset Apr 8, 2015

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.1 milestone Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment