Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gammapy.detect to use gammapy.maps #1564

Merged
merged 7 commits into from Jul 25, 2018

Conversation

@adonath
Copy link
Member

@adonath adonath commented Jul 25, 2018

This PR migrates gammapy.detect to Maps and also does a substantial clean up, especially removing the multiscale ts map helper functions, which are only useful for few user. The functionality was still kept by introducing a downsampling_factor argument in the TSMapEstimator.run() method.

@adonath adonath added the cleanup label Jul 25, 2018
@adonath adonath added this to the 0.8 milestone Jul 25, 2018
@adonath adonath self-assigned this Jul 25, 2018
@adonath adonath added this to To do in gammapy.maps via automation Jul 25, 2018
Copy link
Member

@cdeil cdeil left a comment

I like!

@adonath adonath force-pushed the adonath:migrate_ts_map_to_gp_maps branch from 1bc006a to 876cbb8 Jul 25, 2018
@adonath adonath force-pushed the adonath:migrate_ts_map_to_gp_maps branch from 876cbb8 to 521d754 Jul 25, 2018
@cdeil
cdeil approved these changes Jul 25, 2018
Copy link
Member

@cdeil cdeil left a comment

Looks good. Thanks!

@cdeil cdeil merged commit 7218e80 into gammapy:master Jul 25, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.maps automation moved this from To do to Done Jul 25, 2018
@cdeil cdeil changed the title Migrate gammapy.detect to Maps Migrate gammapy.detect to use gammapy.maps Aug 15, 2018
@adonath adonath deleted the adonath:migrate_ts_map_to_gp_maps branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants