Migrate gammapy.detect to use gammapy.maps #1564
Merged
Conversation
I like! |
1bc006a
to
876cbb8
876cbb8
to
521d754
Looks good. Thanks! |
This was referenced Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR migrates
gammapy.detect
toMaps
and also does a substantial clean up, especially removing the multiscale ts map helper functions, which are only useful for few user. The functionality was still kept by introducing adownsampling_factor
argument in theTSMapEstimator.run()
method.