Remove IACT and Fermi-LAT basic image estimators #1568
Merged
Conversation
This was referenced Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR removes the IACT and Fermi-LAT basic image estimators.
The functionality is mostly replaced by gammapy.maps.
I already opened #1545 and I will open two more reminder issues about this to finish the migration in a good way (basically: RingBackgroundEstimator needs to be migrated, and then the old test case from TestIACTBasicImageEstimator can be migrated into a MapMaker test as well)