/gammapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IACT and Fermi-LAT basic image estimators #1568

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Reviewers
No reviews
Assignees

@cdeil cdeil

Labels
Projects
  
Done in Map analysis
Milestone
  0.8
2 participants
@cdeil @adonath
@cdeil
Member

cdeil commented Jul 25, 2018

This PR removes the IACT and Fermi-LAT basic image estimators.

The functionality is mostly replaced by gammapy.maps.

I already opened #1545 and I will open two more reminder issues about this to finish the migration in a good way (basically: RingBackgroundEstimator needs to be migrated, and then the old test case from TestIACTBasicImageEstimator can be migrated into a MapMaker test as well)

@cdeil cdeil added the cleanup label Jul 25, 2018

@cdeil cdeil added this to the 0.8 milestone Jul 25, 2018

@cdeil cdeil self-assigned this Jul 25, 2018

@cdeil cdeil added this to To do in Map analysis via automation Jul 25, 2018

@adonath adonath merged commit 4115f6c into gammapy:master Jul 25, 2018
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Jul 25, 2018

This was referenced Jul 25, 2018

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment