Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate image measure and profile to use gammapy.maps #1573

Merged
merged 8 commits into from Jul 30, 2018

Conversation

2 participants
@adonath
Copy link
Member

adonath commented Jul 26, 2018

This PR migrates gammapy.image.measure and gammapy.image.profile to gammapy.maps and makes a general clean up. The radial_profile and related methods have been remove, instead a radial option has been added to the ImageProfileEstimator.

@adonath adonath added the cleanup label Jul 26, 2018

@adonath adonath added this to the 0.8 milestone Jul 26, 2018

@adonath adonath self-assigned this Jul 26, 2018

@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Jul 26, 2018

Great, thanks!

Please fix the failing test and then merge:
https://ci.appveyor.com/project/cdeil/gammapy/build/1.0.3884/job/j53iis1ljp5ped9n#L1399

@cdeil cdeil assigned cdeil and unassigned adonath Jul 27, 2018

@cdeil cdeil added this to To do in Map analysis via automation Jul 27, 2018

@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Jul 27, 2018

@adonath - I'm splitting out the mode="edge" for WcsGeom.get_coord` into a separate task: #1578 . I'll make a PR for that tomorrow, and then finish / merge this PR in.

@adonath adonath force-pushed the adonath:migrate_image_measure_to_maps branch from 8ef87f3 to 08e0b10 Jul 30, 2018

@adonath adonath merged commit fb88d57 into gammapy:master Jul 30, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Jul 30, 2018

@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Jul 30, 2018

Wonderful. Thanks for all your work!

@cdeil cdeil changed the title Migrate image measure and profile to maps Migrate image measure and profile to use gammapy.maps Aug 15, 2018

@adonath adonath deleted the adonath:migrate_image_measure_to_maps branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.