Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrate ring background to use gammapy.maps #1582
cdeil left a comment
@registerrier - Thanks!
I did some follow-up edits in 4dbbc78
I had to change to float64 images to get the tests to pass (or reduce accuracy from rtol 1e-7 to 1e6)
I did remove the one-line helper functions to convert between the ring parameters from the docs by removing them from the
I'll merge this now.
One thing I find weird is that the normal ring uses scipy convolve and has no FFT option, and the adaptive ring uses astropy convolve and has an FFT option. Shouldn't it be the same, either FFT is useful to offer or not?
Another suggestion would be to make the test case the same, and to test the FFT option. Pick one good test case and use it for both normal and adaptive ring test, no?
I don't consider those suggestions high priority, so didn't spend time on those here. Just mentioning them since I noticed it here. If you agree, please open a reminder issue to follow up (for v0.9 milestone)