New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FluxPointFitter to use minuit #1606

Merged
merged 6 commits into from Jul 31, 2018

Conversation

2 participants
@adonath
Member

adonath commented Jul 31, 2018

This PR changes the FluxPointFitter class to use the fit_minuit functions. The test values slightly changed in the order of a few percent for the flux amplitude as well as the fit statistics value, which is acceptable. With this change the old SherpaModelWrapper and SherpaDataWrapper classes can be removed.

@adonath adonath added the cleanup label Jul 31, 2018

@adonath adonath added this to the 0.8 milestone Jul 31, 2018

@adonath adonath self-assigned this Jul 31, 2018

@adonath adonath added this to To do in Spectrum analysis (1D) via automation Jul 31, 2018

@adonath adonath added this to In progress in Modeling via automation Jul 31, 2018

@cdeil

cdeil approved these changes Jul 31, 2018

Great. Thanks!

@adonath adonath merged commit a013ff8 into gammapy:master Jul 31, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Spectrum analysis (1D) automation moved this from To do to Done Jul 31, 2018

Modeling automation moved this from In progress to Done Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment