Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove reflected background region finder #1616
Conversation
registerrier
added
the
bug
label
Aug 1, 2018
registerrier
added this to the 0.8 milestone
Aug 1, 2018
registerrier
self-assigned this
Aug 1, 2018
registerrier
added this to To do
in Spectrum analysis (1D)
via automation
Aug 1, 2018
registerrier
requested a review
from
cdeil
Aug 1, 2018
registerrier
referenced this pull request
Aug 1, 2018
Closed
selecting the number of OFF regions in the reflected regions background estimation #1449
cdeil
requested changes
Aug 1, 2018
@registerrier - Thanks!
One suggestion inline above.
Another one would be to improve http://docs.gammapy.org/dev/background/reflected.html a little bit by using this option, and adding links in the text at the top of that page to gammapy.background.ReflectedRegionsFinder so that one can quickly go back and forth between that example page and the API docs.
Finally, it's hard to review this PR locally, because there's fails concerning tevcat_exclusion.fits that was removed a few hours ago. If you want to make that simpler for me, you could rebase this branch against upstream master.
cdeil
changed the title from
Correct reflected bkg
to
Improve reflected background region finder
Aug 1, 2018
registerrier
added some commits
Aug 1, 2018
cdeil
merged commit 19d5746
into
gammapy:master
Aug 1, 2018
Spectrum analysis (1D)
automation
moved this from To do
to Done
Aug 1, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
cdeil
referenced this pull request
Aug 2, 2018
Closed
OFF region determination in SpectrumExtraction v0.6 -> v0.7 #1336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
registerrier commentedAug 1, 2018
this PR proposes a solution to issue #1449 by adding an optional parameter to take only the first
max_region_numberregions that come out of the algorithm.The PR also corrects a bug that could allow the user to create an infinite loop by passing an
increment_angleequal to 0.