Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve reflected background region finder #1616
this PR proposes a solution to issue #1449 by adding an optional parameter to take only the first
The PR also corrects a bug that could allow the user to create an infinite loop by passing an
referenced this pull request
Aug 1, 2018
@registerrier - Thanks!
One suggestion inline above.
Another one would be to improve http://docs.gammapy.org/dev/background/reflected.html a little bit by using this option, and adding links in the text at the top of that page to
gammapy.background.ReflectedRegionsFinder so that one can quickly go back and forth between that example page and the API docs.
Finally, it's hard to review this PR locally, because there's fails concerning
tevcat_exclusion.fits that was removed a few hours ago. If you want to make that simpler for me, you could rebase this branch against upstream master.