Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spectrum energy grouping, use nearest neighbor method #1660

Merged
merged 3 commits into from Aug 7, 2018

Conversation

2 participants
@joleroi
Copy link
Contributor

joleroi commented Aug 7, 2018

This PR addresses issues that have been raised after the coding sprint, e.g. #1638 .
It simplifies the algorithm matching the user binning to the fine binning of an observation. Now nearest neighbour interpolation is used. This has already been suggested at the coding spring by @adonath and @mackaiver

@joleroi joleroi added the feature label Aug 7, 2018

@joleroi joleroi added this to To do in Spectrum analysis (1D) via automation Aug 7, 2018

@joleroi joleroi added this to the 0.8 milestone Aug 7, 2018

@joleroi joleroi force-pushed the joleroi:energy_group branch from 8cfe9f5 to 394bcc4 Aug 7, 2018

@joleroi joleroi force-pushed the joleroi:energy_group branch from 394bcc4 to 913b06d Aug 7, 2018

@cdeil cdeil changed the title Change algorithm in SpectrumEnergyGroupMaker.compute_groups_fixed Fix spectrum energy grouping, use nearest neighbor method Aug 7, 2018

@cdeil

cdeil approved these changes Aug 7, 2018

Copy link
Member

cdeil left a comment

@joleroi - Thanks!

@cdeil cdeil merged commit 57363f8 into gammapy:master Aug 7, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Spectrum analysis (1D) automation moved this from To do to Done Aug 7, 2018

@joleroi joleroi deleted the joleroi:energy_group branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.