This PR is a follow up to #1695. It implements the changes suggested by @cdeil:
Move the convolution unit tests to ´gammapy.maps´
Reintroduce the pixel scale check against the convolution kernel
Use fft convolution in the computation of Li & Ma images as well
Changing to fft convolution in ´compute_lima_image´ did not change the test result (except at the boundary, but I changed the boundary handling on purpose, as the boundary values where previously all set to np.nan), so I presume "ringing" does not seem to be an issue here.
The text was updated successfully, but these errors were encountered:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.