Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TableModel implementation #1710

Merged
merged 3 commits into from Aug 16, 2018

Conversation

@adonath
Copy link
Member

@adonath adonath commented Aug 16, 2018

This PR cleans up the implementation of the TableModel class in gammapy.spectrum. It removes the .plot() method, because it is already in the base class. The case of linear y axis scaling was replaced by a docs example how to modify the y scale. Note that the test reference values remain unchanged.

@adonath adonath added this to the 0.9 milestone Aug 16, 2018
@adonath adonath self-assigned this Aug 16, 2018
@adonath adonath requested a review from joleroi Aug 16, 2018
Copy link
Contributor

@joleroi joleroi left a comment

I've only had a superficial look, but 👍

@adonath
Copy link
Member Author

@adonath adonath commented Aug 16, 2018

Thanks @joleroi! Travis-CI fails are unrelated I'll merge now.

@adonath adonath merged commit 5b9bf8d into gammapy:master Aug 16, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@adonath adonath deleted the adonath:clean_spectrum_table_model branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants