Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataStoreChecker and ObservationChecker #1748

merged 8 commits into from Aug 27, 2018

Add DataStoreChecker and ObservationChecker #1748

merged 8 commits into from Aug 27, 2018


Copy link

@cdeil cdeil commented Aug 27, 2018

This PR introduces a DataStoreChecker and ObservationChecker.

The basic idea is to yield records, which are dicts, and to let callers filter or format those record.
This is simple and efficient in Python, this would even allow writing the stream of records without making a list, i.e. allows checking a lot of data without memory increasing if we used lists.

I will make another PR tonight removing the EventListDatasetChecker (which is mostly broken), and to add the useful checks from there (with tests) to the ObservationChecker.

cc @dcfidalgo @maxnoe

@cdeil cdeil added this to the 0.8 milestone Aug 27, 2018
@cdeil cdeil self-assigned this Aug 27, 2018
@cdeil cdeil added this to To do in via automation Aug 27, 2018
@cdeil cdeil merged commit af79dd6 into gammapy:master Aug 27, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details automation moved this from To do to Done Aug 27, 2018
@cdeil cdeil changed the title Introduce DataStoreChecker and ObservationChecker Add DataStoreChecker and ObservationChecker Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant