Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventListDataset class #1750

merged 1 commit into from Aug 28, 2018

Remove EventListDataset class #1750

merged 1 commit into from Aug 28, 2018


Copy link

@cdeil cdeil commented Aug 28, 2018

This PR removes the EventListDataset class.

It was a container for an EventList and a GTI object. It was never clear if we want this class or if we want to add a GTI object to the one EventList class. This EventListDataset class was completely unused, and mostly broken and untested.

After discussion with @adonath we decided to remove it for now, and then add GTI handling in Gammapy after some more thought / discussion in the future, either on the EventList class, or add that functionality on the Observation classes. (cc @dcfidalgo and @registerrier )

The EventListDatasetChecker is also mostly unfinished / broken. I'll clean that up and hook those checks up to the DataStoreChecker in a follow-up PR later today.

@dcfidalgo - FYI: I'm working on that stuff now, because we are preparing some IACT data releases and want to have those checkers in place.

@cdeil cdeil added the cleanup label Aug 28, 2018
@cdeil cdeil added this to the 0.8 milestone Aug 28, 2018
@cdeil cdeil self-assigned this Aug 28, 2018
@cdeil cdeil added this to To do in via automation Aug 28, 2018
@cdeil cdeil merged commit 1808962 into gammapy:master Aug 28, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details automation moved this from To do to Done Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant