Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EventList and data checkers #1751

Merged
merged 15 commits into from Aug 28, 2018

Conversation

Projects
1 participant
@cdeil
Copy link
Member

cdeil commented Aug 28, 2018

This PR contains a few improvements and a lot of cleanup in gammapy.data (mostly EventList and DataStore) and improvement to the data checkers. It continues #1748 and #1750 .

This has no effect on high-level analyses, except for the edge case where someone was calling event_list.galactic and the GLON / GLAT columns in the event list table were filled incorrectly. This will probably lead to tiny shifts on the order of less than an arcsec for Fermi-LAT event lists, so cc @adonath - just in case you see tiny differences in counts maps after this change. The difference is known, Fermi-LAT is using a mix of FK5 and ICRS in software, and we are using consistently ICRS system.

There's still more work to do, I've left TODO comments in the checkers. Not sure if I'll have time for another PR this week, I'll try.

@cdeil cdeil added this to the 0.8 milestone Aug 28, 2018

@cdeil cdeil self-assigned this Aug 28, 2018

@cdeil cdeil added this to To do in Data via automation Aug 28, 2018

@cdeil cdeil merged commit c5899e9 into gammapy:master Aug 28, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Data automation moved this from To do to Done Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.