Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add find_peaks for images #1759
We have two tutorial notebooks that show how to use
There was a change in photutils 0.5:
And I also put a compatibility code in
I would suggest to put some
For the notebooks: maybe we could / should avoid the duplication, and just show how to do it once and add a link to the other?
A very commmon question is how to plot region circles. I think this example would be the best place to show that, making a regions circle object and plotting it instead of calling
@adonath - Thoughts on what exactly to do? Do you have time in the next days of should I?
In this case I think it's also justified to drop the support for the older version. Right now it's the only place in gammapy or gammapy-extra where we use photutils. One could update the https://github.com/gammapy/gammapy-extra/blob/master/environment.yml and require photutils >= 0.5.
Users can always easily update their existing environments using:
Maybe we should document this somewhere...
@adonath - I did decide to add
CI is broken at the moment (known issue: astropy/ci-helpers#308), so I'll merge this now and update the notebooks.
But @adonath - of course your review here is still welcome. If you want to improve something, feel free to do it directly via a follow-up commit in master.