Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Format all code in Gammapy black #1764
This PR runs
This is a safe transform, the resulting code will execute identically as before always. The only question here is about code style.
Personally I like most of the changes, but there's also quite a few where I think there's too many line breaks. But overall I'm +1 to do this now and then keep the code black, because then we never have to think or discuss about code formatting, that question is removed. (and when we get contributions, we don't even have to review / discuss code style, we just ask people to run
I agree the results are good and I think we should make the transition to use
If we decide to make this change, we should of course add a new section on the developer's how to docs page.
I spent a bit of time to manually improve code formatting based on the diff here. But I only got through ~ a third I think and as discussed above this work can be continued later.
I'll do one more commit where I remove the