Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Unify API of Gammapy Fit classes #1785
This PR unifies the current Gammapy
This PR also makes a few minor changes to the
@adonath - This looks great, thank you!
Suggest to change the key
best-fit-model to just
model in the results object? The other is a bit long to remember and type.
The other question I have is if we need both
total_stat, and whether the use is consistent. So
stat is per bin, and
total_stat is the sum, possibly taking a mask into account? Maybe
stat_sum would be clearer? What names dis Sherpa choose? If you don't have time to look at this, OK to leave as-is.
There's one link in one notebook that needs to be updated with the rename:
@adonath - Please merge this when you can tomorrow, so that we can continue testing and using this a bit this week.