Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EnergyDispersion write and to_sherpa #1799

Merged
merged 2 commits into from Sep 17, 2018

Conversation

@registerrier
Copy link
Contributor

@registerrier registerrier commented Sep 17, 2018

…grp>1

This should provide a correction to cases where the RMF is stored with some true energies have n_grp>1.

@registerrier registerrier requested a review from cdeil Sep 17, 2018
@@ -139,7 +139,7 @@ def test_all(self):
# TODO: fix the to_sherpa

This comment has been minimized.

@cdeil

cdeil Sep 17, 2018
Member

Please remove the TODO comment lines.

Copy link
Member

@cdeil cdeil left a comment

@registerrier - Thanks!

Please either merge when CI passes, or if you want to wait a bit to give @joleroi a chance to review this, please merge by tomorrow latest.

@cdeil cdeil added the bug label Sep 17, 2018
@cdeil cdeil added this to To do in gammapy.makers via automation Sep 17, 2018
@cdeil cdeil added this to the 0.8 milestone Sep 17, 2018
@cdeil cdeil changed the title Correction for EnergyDispersion.to_sherpa() when some entries have n_… Fix EnergyDispersion write and to_sherpa Sep 17, 2018
@registerrier registerrier merged commit db61cdc into gammapy:master Sep 17, 2018
1 of 4 checks passed
1 of 4 checks passed
Scrutinizer Analysis: Errored – Tests: failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
gammapy.makers automation moved this from To do to Done Sep 17, 2018
@registerrier registerrier deleted the registerrier:issue_rmf_ngrp branch Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants