Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObservationTableChecker and improve EVENTS checker #1800

Merged
merged 2 commits into from Sep 17, 2018

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Sep 17, 2018

This PR adds a first version of an ObservationTableChecker, and also adds a check for the RA_PNT and DEC_PNT header keys of the EventListChecker. This was an important oversight in the spec (open-gamma-ray-astro/gamma-astro-data-formats#130) and in the checker.

@cdeil cdeil added the feature label Sep 17, 2018
@cdeil cdeil added this to the 0.8 milestone Sep 17, 2018
@cdeil cdeil self-assigned this Sep 17, 2018
@cdeil cdeil added this to To do in gammapy.data via automation Sep 17, 2018
@cdeil cdeil merged commit f0fab6d into gammapy:master Sep 17, 2018
0 of 4 checks passed
0 of 4 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.data automation moved this from To do to Done Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.data
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant