Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fit likelihood profile method #1812

Merged
merged 8 commits into from Sep 21, 2018
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Sep 20, 2018

This PR adds a .likelihood_profile() method to the Fit object, which can be used to compute likelihood profiles for given parameters. The computed likelihood profiles are also added to the FitResult object, which features a convenience method to plot those. The old SpectrumFit likelihood profile methods are deleted.

@adonath adonath added this to the 0.8 milestone Sep 20, 2018
@adonath adonath self-assigned this Sep 20, 2018
@adonath adonath added this to In progress in gammapy.modeling via automation Sep 20, 2018
@adonath adonath force-pushed the adonath:likelihood_profiles branch from 403b355 to f9d4b07 Sep 20, 2018
@adonath adonath merged commit 994e953 into gammapy:master Sep 21, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer Analysis: 18 new issues, 8 updated code elements – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gammapy.modeling automation moved this from In progress to Done Sep 21, 2018
@cdeil cdeil changed the title Add likelihood profile methods to Fit Add Fit likelihood profile method Sep 23, 2018
@adonath adonath deleted the adonath:likelihood_profiles branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant