Join GitHub today
Use GAMMAPY_DATA in Gammapy codebase #1822
This PR replaces
We can see
I have left
I'm afraid developers should have
Local regression test pass, and three notebooks remain broken for those not having
I don't have it pointing to the same path. I just have them separately.
Since not all files from GAMMAPY_DATA come from gammapy-extra (maybe that's still the case, but it won't remain like this), I think the proper dev setup is to just have them separately.
We can consider completely raplacing the use of GAMMAPY_EXTRA by GAMMAPY_DATA, also for test files, but that might not be a great solution (exposing test datasets to users a bit), and anyways isn't high priority.
I think for devs it's acceptable to have an extra 5 min of setup and to clone and set up GAMMAPY_EXTRA as well. Of course, we need to improve the Gammapy developer docs and explain the steps / setup clearly, but then I think it'll be OK.
@Bultako - Thanks!
Let me know if I should do anything (e.g. edit notebooks).
For gamma-cat, it's particularly complicated because it's a "live catalog", the version at https://gamma-cat.readthedocs.io/output/gammacat.fits.gz can change any day if a new source is discovered and if someone has time to make a data entry there.
But for testing and tutorials, we probably want a fixed, pre-downloaded version.
That makes it especially complicated.
But let's leave that discussion for another day, and for now everywhere just use the fixed version in gammapy-extra.