Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FluxPointProfiles class #1854

Merged
merged 2 commits into from Oct 19, 2018
Merged

Add FluxPointProfiles class #1854

merged 2 commits into from Oct 19, 2018

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Oct 4, 2018

I've written a first draft of a FluxPointProfiles class.

I think there's still a bug in plot_sed. But I don't have a good test case, so before continuing with this, I'll try to add a FluxPointEstimator.compute_profiles method.

@cdeil cdeil added the feature label Oct 4, 2018
@cdeil cdeil added this to the 0.9 milestone Oct 4, 2018
@cdeil cdeil self-assigned this Oct 4, 2018
@cdeil cdeil added this to To do in gammapy.makers via automation Oct 4, 2018
@cdeil cdeil requested a review from adonath Oct 4, 2018
@cdeil
Copy link
Member Author

@cdeil cdeil commented Oct 19, 2018

I'll merge this in now, and open a follow-up issue concerning the computation of these profiles,
because I don't have time for this, and the FluxPointEstimator has issues that require someone to spend at least a day or two to make it better.

@cdeil cdeil merged commit 2490b46 into gammapy:master Oct 19, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 2574 new issues, 19 updated code elements – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gammapy.makers automation moved this from To do to Done Oct 19, 2018
@cdeil
Copy link
Member Author

@cdeil cdeil commented Oct 19, 2018

I left a comment here how to continue: #1635 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.