New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in MapFit energy dispersion apply #1859

Merged
merged 1 commit into from Oct 5, 2018

Conversation

2 participants
@registerrier
Contributor

registerrier commented Oct 5, 2018

This provides a correction to a bug in apply_edisp.
It passed the test because the energy axis length in 3 in the test.

@registerrier registerrier added the bug label Oct 5, 2018

@registerrier registerrier added this to the 0.9 milestone Oct 5, 2018

@registerrier registerrier self-assigned this Oct 5, 2018

@registerrier registerrier added this to In progress in Modeling via automation Oct 5, 2018

@registerrier registerrier added this to To do in Map analysis via automation Oct 5, 2018

@registerrier registerrier requested a review from AtreyeeS Oct 5, 2018

@cdeil

cdeil approved these changes Oct 5, 2018

Thanks!

@cdeil cdeil merged commit 9f44258 into gammapy:master Oct 5, 2018

0 of 4 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Map analysis automation moved this from To do to Done Oct 5, 2018

Modeling automation moved this from In progress to Done Oct 5, 2018

@cdeil cdeil changed the title from correction to MapFit.apply_edisp to Fix in MapFit energy dispersion apply Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment