Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve analysis3d tutorial notebook #1884

Merged
merged 7 commits into from Oct 22, 2018
Merged

Conversation

@IAMinaya
Copy link
Contributor

@IAMinaya IAMinaya commented Oct 19, 2018

Continuing pull request #1860 ...

As suggested, I left this notebook with the original dataset (no need of CTADATA, FERMI or GAMMAPY_EXTRA anymore) but including the part of the galactic diffuse emission subtraction. I also attached the static image at the end of the notebook, as well as the path to access the complete notebook already submitted into GAMMAPY-EXTRA.

P.S. The previous branch was "too old" and to avoid conflicts with some functions that were modified I created a new branch... I tried to keep everything in the same commit but apparently I failed! apologies, next time I will try with git rebase.

@cdeil cdeil self-assigned this Oct 22, 2018
@cdeil cdeil added this to the 0.9 milestone Oct 22, 2018
@cdeil cdeil added the docs label Oct 22, 2018
@cdeil cdeil added this to To Do in DOCUMENTATION via automation Oct 22, 2018
@cdeil cdeil changed the title Improved analysis_3d.ipynb (v2) Improve analysis3d tutorial notebook Oct 22, 2018
tutorials/analysis_3d.ipynb Outdated Show resolved Hide resolved
"metadata": {},
"outputs": [],
"source": [
"diffuse_model = SkyDiffuseCube.read(\"$GAMMAPY_EXTRA/datasets/fermi_3fhl/gll_iem_v06_cutout.fits\")"

This comment has been minimized.

@Bultako

Bultako Oct 22, 2018
Member

Suggested change
"diffuse_model = SkyDiffuseCube.read(\"$GAMMAPY_EXTRA/datasets/fermi_3fhl/gll_iem_v06_cutout.fits\")"
"diffuse_model = SkyDiffuseCube.read(\"$GAMMAPY_DATA/fermi_3fhl/gll_iem_v06_cutout.fits\")"
"cell_type": "markdown",
"metadata": {},
"source": [
"(the complete tutorial notebook of this analysis is available to be ran through [GAMMAPY-EXTRA](https://github.com/gammapy/gammapy-extra) on $GAMMAPY_EXTRA/analyses/cta_1dc_gc_3d.ipynb)"

This comment has been minimized.

@Bultako

Bultako Oct 22, 2018
Member

Suggested change
"(the complete tutorial notebook of this analysis is available to be ran through [GAMMAPY-EXTRA](https://github.com/gammapy/gammapy-extra) on $GAMMAPY_EXTRA/analyses/cta_1dc_gc_3d.ipynb)"
"(the complete tutorial notebook of this analysis is available to be downloaded in [GAMMAPY-EXTRA](https://github.com/gammapy/gammapy-extra) repository at https://github.com/gammapy/gammapy-extra/blob/master/analyses/cta_1dc_gc_3d.ipynb)"
tutorials/analysis_3d.ipynb Outdated Show resolved Hide resolved
@cdeil cdeil assigned Bultako and unassigned cdeil Oct 22, 2018
Copy link
Member

@cdeil cdeil left a comment

@IAMinaya - Thanks!

@Bultako - Can you please apply your suggestions and merge?

(I'm not sure if I'm seeing a correct view on Github at the moment, and am leaving for today)

Co-Authored-By: IAMinaya <ignaciominaya@gmail.com>
Co-Authored-By: IAMinaya <ignaciominaya@gmail.com>
@IAMinaya
Copy link
Contributor Author

@IAMinaya IAMinaya commented Oct 22, 2018

Ups! You are right @Bultako , thanks! I forgot to change that last $GAMMAPY_EXTRA (I did it as a local test and apparently I forgot to undo it...). I have applied your suggestions and commited the changes through the website.

@Bultako Bultako merged commit 44be96a into gammapy:master Oct 22, 2018
DOCUMENTATION automation moved this from To Do to Done Oct 22, 2018
@Bultako
Copy link
Member

@Bultako Bultako commented Oct 22, 2018

Ok.
Modifs committed and PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
DOCUMENTATION
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants