New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change map quantity to view instead of copy #1890

Merged
merged 1 commit into from Oct 26, 2018

Conversation

2 participants
@registerrier
Contributor

registerrier commented Oct 26, 2018

This PR is a small modification on Map.quantity to return a view on the Quantity object instead of creating it with a copy of Map.data.
The change is made on the property and on the setter.

@registerrier registerrier added this to the 0.9 milestone Oct 26, 2018

@registerrier registerrier self-assigned this Oct 26, 2018

@registerrier registerrier added this to To do in Map analysis via automation Oct 26, 2018

@registerrier registerrier referenced this pull request Oct 26, 2018

Closed

Map arithmetics #1885

@registerrier

This comment has been minimized.

Contributor

registerrier commented Oct 26, 2018

This is a very small modification. Tests pass correctly. Merging now.

@registerrier registerrier merged commit 516a558 into gammapy:master Oct 26, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer Analysis: 545 new issues – Tests: passed
Details

Map analysis automation moved this from To do to Done Oct 26, 2018

@cdeil cdeil changed the title from Map.quantity as a view to Change map quantity to view instead of copy Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment