Comment line is too long. IMO "Test equality between two ~gammapy.maps.WcsGeom." doesn't add value and could be removed. The commend about WCS and 1e6 I would put inline above the line where you call the corresponding method.
Also here: I would not introduce a local state variable "result" that you accumulate. Just check things and return False if not equal one by one, and put return True on the last line.
I think I've seen that coding pattern a lot in Python codes.
Also here, I would suggest to try and reduce the lines of test code if possible.
We already have many 1000s too much and it's hard to maintain.
Concretely, I think we shouldn't even try to exhaustively test astropy.wcs.WCS properties, but just rely that that compare works, and just have 1 or 2 explicit cases where it's the same and we get True and one where it's off by 1e-3 and False.
And the whole @pytest.mark.parametrize can be removed and the test cases in the test function, if there's only one line for each the test parametrisation doesn't by you anything, no?
Matter of taste - feel free to finish up as you like an merge.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.