Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scipy as core dependency #1919

Merged
merged 8 commits into from Nov 13, 2018
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Nov 12, 2018

As discussed in #1863, this PR adds Scipy as a core dependency for Gammapy:

  • Add Scipy as a core dependency in setup.py
  • Remove the calls to requires_dependency("scipy")
  • Move delayed imports to the top
@adonath adonath self-assigned this Nov 12, 2018
@adonath adonath added this to the 0.9 milestone Nov 12, 2018
@adonath adonath requested a review from Bultako Nov 12, 2018
Copy link
Member

@cdeil cdeil left a comment

Thanks!

For all the removed @requires_dependency you added a third empty line between functions, where PEP says it should be 2. Maybe just run make black as a follow-up commit?

@adonath adonath dismissed stale reviews from Bultako and cdeil via 763aeec Nov 13, 2018
@adonath adonath force-pushed the adonath:scipy_core_dependency branch from 3742c82 to 763aeec Nov 13, 2018
@adonath adonath merged commit fb7b218 into gammapy:master Nov 13, 2018
2 of 5 checks passed
2 of 5 checks passed
@azure-pipelines
gammapy.gammapy Build #20181113.3 has test failures
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 81 new issues, 1 updated code elements – Tests: passed
Details
@adonath adonath deleted the adonath:scipy_core_dependency branch Nov 20, 2018
@cdeil
Copy link
Member

@cdeil cdeil commented Nov 23, 2018

I also removed all pytest.importorskip("scipy") just now: 228907f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants