New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and improve ScaledRegularGridInterpolator #1921

Merged
merged 5 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Nov 13, 2018

This PR implements the following changes:

  • Add Quantity handling and broadcasting to ScaledRegularGridInterpolator
  • Use the ScaledRegularGridInterpolator in hess.py
  • Adapt the TableModel to the changes
  • Adapt NDData.evaluate to the changes, especially change it to follow Numpy broadcasting rules.
  • Remove NDData.evaluate_at_coord(), because it is not needed anymore.

@adonath adonath added the cleanup label Nov 13, 2018

@adonath adonath added this to the 0.9 milestone Nov 13, 2018

@adonath adonath self-assigned this Nov 13, 2018

@cdeil

cdeil approved these changes Nov 13, 2018

Thanks!

@adonath adonath merged commit 3dece89 into gammapy:master Nov 13, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer Analysis: 2514 new issues, 1 updated code elements – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@adonath adonath deleted the adonath:unify_interpolation branch Nov 20, 2018

@cdeil cdeil changed the title from Unify interpolation and add broadcasting to ScaledRegularGridInterpolator to Use and improve ScaledRegularGridInterpolator Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment