Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FluxPointEstimator test and docs #1934

merged 11 commits into from Nov 19, 2018


Copy link

@adonath adonath commented Nov 19, 2018

This PR includes test and docs improvements for the FluxPointEstimator:

  • Add a dedicated test_flux_point_esti, file, where test are run on a simulated observation for pwl as well as ecpl models
  • Add a nice likelihood profile plot to spectrum_analysis.ipynb

There a few minor unrelated changes:

  • Move the __str__ of to the Model base class
  • Add the frozen parameter attribute to the Parameters.to_table() method
@adonath adonath self-assigned this Nov 19, 2018
@adonath adonath added this to To do in gammapy.makers via automation Nov 19, 2018
@adonath adonath added this to the 0.9 milestone Nov 19, 2018
@adonath adonath merged commit 0ee6c8e into gammapy:master Nov 19, 2018
1 of 5 checks passed
1 of 5 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
gammapy.gammapy Build #20181119.3 has test failures
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Scrutinizer Analysis: 4 new issues, 13 updated code elements – Tests: passed
gammapy.makers automation moved this from To do to Done Nov 19, 2018
@adonath adonath deleted the adonath:flux_point_estimator_improvements branch Nov 20, 2018
@cdeil cdeil changed the title FluxPointEstimator test and docs improvements Improve FluxPointEstimator test and docs Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant