Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data access in notebooks to GAMMAPY_DATA #1962

Merged
merged 4 commits into from Nov 30, 2018

Conversation

@Bultako
Copy link
Member

@Bultako Bultako commented Nov 29, 2018

This PR follows the suggestion in comment #1958 (comment) to use $GAMMAPY_DATA instead of $GAMMAPY_FERMI_LAT_DATA in one of the tutorials. The other two cannot be modified easily since they use SourceCatalogGammaCat, so access to the datasets is hardcoded in this class.

@cdeil
Copy link
Member

@cdeil cdeil commented Nov 29, 2018

👍 to this change, thanks!

@Bultako - You can pass a path to SourceCatalogGammaCat, using this from the tutorial should do the trick:

cat = SourceCatalogGammaCat("$GAMMAPY_DATA/some/where/gammacat.fits")
@Bultako
Copy link
Member Author

@Bultako Bultako commented Nov 29, 2018

@cdeil

Thanks, it works with your suggestions above. I've added the other two notebooks modified. Now, we do not have any notebook broken because of missing datasets.
I'll merge when CI tests pass.

@cdeil cdeil added the docs label Nov 29, 2018
@cdeil cdeil added this to To Do in DOCUMENTATION via automation Nov 29, 2018
@cdeil cdeil modified the milestones: 0.11, 0.10 Nov 29, 2018
Copy link
Member

@cdeil cdeil left a comment

Nice! Thank you!

@cdeil cdeil changed the title Modif fermi_lat notebook to use GAMMAPY_DATA Change data access from all notebooks to GAMMAPY_DATA Nov 29, 2018
@Bultako Bultako force-pushed the Bultako:fix-notebooks branch from 02ebcb9 to ef77c70 Nov 30, 2018
@Bultako Bultako force-pushed the Bultako:fix-notebooks branch from 2ee7c49 to 79644ae Nov 30, 2018
@Bultako Bultako merged commit cfb9769 into gammapy:master Nov 30, 2018
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20181130.6 succeeded
Details
DOCUMENTATION automation moved this from To Do to Done Nov 30, 2018
@Bultako Bultako deleted the Bultako:fix-notebooks branch Dec 3, 2018
@cdeil cdeil changed the title Change data access from all notebooks to GAMMAPY_DATA Change data access in notebooks to GAMMAPY_DATA Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DOCUMENTATION
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants