Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ObservationStats #1969

Merged
merged 1 commit into from Dec 7, 2018
Merged

Improve ObservationStats #1969

merged 1 commit into from Dec 7, 2018

Conversation

@lmohrmann
Copy link
Contributor

@lmohrmann lmohrmann commented Dec 6, 2018

Following #1955, this PR improves the ObservationStats class and the associated tests. Note that several superfluous parameters to __init__ have been removed. This should rarely lead to problems, since instances of this class are usually created by the from_observation factory function.

@lmohrmann lmohrmann requested a review from cdeil Dec 6, 2018
@adonath adonath added the cleanup label Dec 7, 2018
@adonath adonath added this to To do in gammapy.makers via automation Dec 7, 2018
@adonath adonath removed this from To do in gammapy.makers Dec 7, 2018
@adonath adonath added this to the 0.10 milestone Dec 7, 2018
@adonath adonath self-assigned this Dec 7, 2018
@adonath adonath merged commit 48a822f into gammapy:master Dec 7, 2018
4 of 5 checks passed
4 of 5 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer Analysis: 7 updated code elements – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@azure-pipelines
gammapy.gammapy Build #20181206.3 succeeded
Details
@adonath
Copy link
Member

@adonath adonath commented Dec 7, 2018

Thanks, @lmohrmann!

@lmohrmann lmohrmann deleted the lmohrmann:improve-obs-stats branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants