Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SourceCatalogObjectHGPS spatial model #1991

Merged
merged 2 commits into from Jan 21, 2019
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Jan 18, 2019

This PR addresses #1351. It implements the following changes:

  • Allow for choosing the spectral model in SourceCatalogObjectHGPS.sky_model()
  • Change SourceCatalogObjectHGPS.sky_model() to return the correct spectrum for 2-gaussian and 3-gaussian sources
  • Add gammacat and hgps to the catalog registry, because both are available via $GAMMAPY_DATA now.
@adonath adonath added this to the 0.10 milestone Jan 18, 2019
@adonath adonath self-assigned this Jan 18, 2019
@adonath adonath force-pushed the adonath:issue_#1351 branch from 8bc4b1a to df674b5 Jan 21, 2019
@adonath adonath merged commit 4c6b8a2 into gammapy:master Jan 21, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
@azure-pipelines
gammapy.gammapy Build #20190121.1 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant