Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyyaml as core dependency #1995

Merged
merged 2 commits into from Jan 22, 2019
Merged

Add pyyaml as core dependency #1995

merged 2 commits into from Jan 22, 2019

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Jan 22, 2019

This PR adds pyyaml as a core dependency of Gammapy.

In practice this means that we list pyyaml in install_requires in setup.py, and that pip install gammapy will always install pyyaml automatically as a dependency if it isn't already present.

We currently mostly use YAML to read ECSV files, as well as for the gammapy download functionality. We already use it for model serialisation a bit, and plan to use it more extensively in the future (xref #329). Very likely YAML will be used in the high-level Gammapy interface as config file format (and for model serialisation), so really the vast majority of users will need it. Fermipy does already use it, so this is not adding an extra dependency for them.

The changes here are similar to what @adonath did when we made Scipy a core dependency in #1919 - mostly moving imports to the top and removing a few requires_dependency decorators on tests. I plan to mention this clearly in the changelog, but in a follow-up PR.

@cdeil cdeil added this to the 0.10 milestone Jan 22, 2019
@cdeil cdeil self-assigned this Jan 22, 2019
@cdeil cdeil requested review from Bultako and adonath Jan 22, 2019
@cdeil cdeil mentioned this pull request Jan 22, 2019
1 of 2 tasks complete
Copy link
Member

@adonath adonath left a comment

Looks good to me, I have no further comments.

Copy link
Member

@Bultako Bultako left a comment

👍

@cdeil cdeil merged commit 69e1274 into gammapy:master Jan 22, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy Build #20190122.6 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants