Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FluxPointsDatasets class #2023

Merged
merged 4 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@adonath
Copy link
Member

adonath commented Feb 5, 2019

This PR refactors the existing FluxPointsFit into a FluxPointsDataset class, as a first example of the Dataset framework we plan to implement for Gammapy.

@adonath adonath self-assigned this Feb 5, 2019

@adonath adonath added this to the 0.11 milestone Feb 5, 2019

@adonath adonath added the feature label Feb 6, 2019

@adonath adonath force-pushed the adonath:flux_points_dataset branch from 5c14c3f to 06d8456 Feb 6, 2019

@adonath adonath merged commit e336412 into gammapy:master Feb 6, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 11 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

def total_stat(self, parameters):
def likelihood(self, parameters):

This comment has been minimized.

Copy link
@AtreyeeS

AtreyeeS Feb 8, 2019

Member

Hello @adonath ! I was wondering why you are passing parameters here?

This comment has been minimized.

Copy link
@adonath

adonath Feb 8, 2019

Author Member

That's a left over from the previous implementation of total_stat(). It could be just removed here and in SpectrumFit.total_stat as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.