Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add SkyEllipse model #2046
adonath left a comment
Thanks @luca-giunti! I've left a few in-line comments mainly concerning the code style. I really like the example plot. It's very illustrative. We should consider adding one for the other models as well.
My main comment would be to add a second test, using a larger ellipse radius to better check the normalization.