Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WcsGeom.cutout() method #2051

Merged
merged 1 commit into from Feb 27, 2019

Conversation

3 participants
@JouvinLea
Copy link
Contributor

JouvinLea commented Feb 27, 2019

This PR implemnt the cutout on the WCS class.
Allow to optimize a bit the MapMaker class to avoid to perform the cutout on the map directly to get the associated coord but directly on the wcs.

@JouvinLea JouvinLea requested a review from registerrier Feb 27, 2019

@registerrier
Copy link
Contributor

registerrier left a comment

This looks OK. Thanks @JouvinLea.
Because of the slicing, I suppose it is difficult to use WcsGeom.cutout in WcsNDMap.cutout.

@adonath adonath self-assigned this Feb 27, 2019

@adonath adonath added the feature label Feb 27, 2019

@adonath adonath added this to To do in Map analysis via automation Feb 27, 2019

@adonath adonath added this to the 0.11 milestone Feb 27, 2019

@adonath adonath merged commit f6cf679 into gammapy:master Feb 27, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Map analysis automation moved this from To do to Done Feb 27, 2019

@adonath adonath changed the title Cutout on WCS Add WcsGeom.cutout() method Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.