Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluation radius to SkyEllipse model #2065

Merged

Conversation

Projects
2 participants
@luca-giunti
Copy link
Contributor

luca-giunti commented Mar 1, 2019

I added the evaluation_radius property for the SkyEllipse model, and its test. Other small changes come from black

@luca-giunti luca-giunti requested a review from JouvinLea Mar 1, 2019

@adonath

adonath approved these changes Mar 1, 2019

Copy link
Member

adonath left a comment

Thanks @luca-giunti! I have no further comments.

@adonath adonath self-assigned this Mar 1, 2019

@adonath adonath added the feature label Mar 1, 2019

@adonath adonath added this to In progress in Modeling via automation Mar 1, 2019

@adonath adonath added this to the 0.11 milestone Mar 1, 2019

@adonath adonath merged commit 0bf7250 into gammapy:master Mar 1, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Modeling automation moved this from In progress to Done Mar 1, 2019

@adonath adonath changed the title Added evaluation radius for the SkyEllipse model, and a test Add evaluation radius to SkyEllipse model Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.