Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy.datasets submodule #2098

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
1 participant
@adonath
Copy link
Member

adonath commented Mar 28, 2019

Now that we have the gammapy download command and are using the $GAMMAPY_DATA env variable consistently everywhere, there is no reason to keep the old gammapy.datasets submodule.

If we decide to introduce a class and function based access to $GAMMAPY_DATA again we have to build it from the scratch anyway. For now I prefer to just remove it, because it appears uselessly in the docs and has the name collision with our Datasets classes, which could cause confusion.

Addresses #1237.

@adonath adonath self-assigned this Mar 28, 2019

@adonath adonath added this to the 0.11 milestone Mar 28, 2019

@adonath adonath added the cleanup label Mar 28, 2019

@adonath adonath force-pushed the adonath:clean_up_datasets_submodule branch from f22c364 to 08f4b25 Mar 28, 2019

@adonath adonath merged commit cef41f4 into gammapy:master Mar 28, 2019

0 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.